[Monitor] Improve docs regarding sovereign clouds #33196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvaneck
force-pushed
the
ingestion-docs
branch
2 times, most recently
from
be313f9 to
cc38c88
Compare
Collaborator
|
API change check API changes are not detected in this pull request. |
pvaneck
force-pushed
the
ingestion-docs
branch
from
cc38c88 to
3c39223
Compare
pvaneck
requested review from
KarishmaGhiya,
gracewilcox,
joshfree,
nisha-bhatia,
sarangan12,
scottaddie and
srnagar
scottaddie
reviewed
Nov 17, 2023
sdk/monitor/azure-monitor-ingestion/samples/sample_authentication.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-ingestion/samples/async_samples/sample_authentication_async.py
Outdated
Show resolved
Hide resolved
pvaneck
force-pushed
the
ingestion-docs
branch
from
3c39223 to
fe5ad7d
Compare
pvaneck
force-pushed
the
ingestion-docs
branch
from
fe5ad7d to
c4b6ee9
Compare
Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
force-pushed
the
ingestion-docs
branch
from
c4b6ee9 to
6276730
Compare
kristapratico
approved these changes
Mar 12, 2024
Contributor
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
Looks really good! Just wondering, do we already have tests that test against sovereign clouds?
Member
Author
Not yet in the CI, however I have manually tested on sovereign clouds several times. One of my work items this semester is to validate sovereign cloud support for a new batch metrics client, so I'll definitely use that as the opportunity to setup US/China cloud testing in the weekly pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since non-public cloud usage is a common usage scenario with this SDK, I am adding some samples and snippets to showcase usage with non-public clouds.